[8.x ] Update Cursor.php #37458
Merged
[8.x ] Update Cursor.php #37458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Order by column that can be null given me "Unable to find parameter [last_answer] in pagination item.". I solved it by this change and make 2 orders by, first is the id that won't be null, second is "last_answer" that can be null, and worked.
|
If there are tests for Cursor it is good to cover this case too |
|
@antonkomarev |
|
I think this PR is good to go. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order by column that can be null given me "Unable to find parameter [last_answer] in pagination item.".
I solved it by this change and make 2 orders by, first is the id that won't be null, second is "last_answer" that can be null, and worked.